Remove Sampler and its interface
#1037
Open
+13
−411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
changed the base branch from
breaking
to
py/remove-samplingcontext
Benchmark Report for Commit 35d0be2Computer InformationBenchmark Results |
penelopeysm
force-pushed
the
py/remove-samplingcontext
branch
2 times, most recently
from
0b87d0d to
992569f
Compare
penelopeysm
force-pushed
the
py/no-sampler
branch
from
35d0be2 to
e5e98e1
Compare
|
DynamicPPL.jl documentation for PR #1037 is available at: |
penelopeysm
changed the title
Sampler and initialstepSampler and its interface
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## breaking #1037 +/- ##
============================================
- Coverage 82.40% 82.20% -0.21%
============================================
Files 42 41 -1
Lines 3791 3765 -26
============================================
- Hits 3124 3095 -29
- Misses 667 670 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
As title. Essentially, this deletes the entirety of
src/sampler.jl.why
Because the type
Sampleris gone, and also because DynamicPPL has no more actual samplers (in the past there wereSampleFromPrior()andSampleFromUniform()that were actually samplers) that means we don't need to declare generic methods forAbstractMCMC.samplein DynamicPPL. That also means that the supporting interface used to define e.g. keyword argument defaults can also go.Of course, it doesn't go completely: it just gets shifted upwards to Turing. In my opinion that makes a ton more sense anyway because that's where the concrete implementations of
sample()are written. The current status is that these functions are defined in DynamicPPL but no methods are defined anywhere in DPPL, only in Turing. So may as well move the actual function there.On top of this, the default implementation for
samplewas actually too restrictive in that it doesn't allow forAbstractMCMC.step_warmupto callDynamicPPL.initialstep. This means that you can't have a customstep_warmupfor Turing samplers.where now
My plan for which function goes where is outlined in the changelog:
DynamicPPL.jl/HISTORY.md
Lines 45 to 55 in be0d2ad
For the upcoming release of Turing v0.41 I will just do a straight copy paste of the code here, instead of doing any larger refactoring. But I would like this PR to be in DPPL 0.38 so that we don't have to cut a new minor version just to delete this.